schema: Annotations to oneOf and add oneOfEnumSelectorField #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
64-annotations-oneOf
branch
7 times, most recently
from
be36f4a to
03cac59
Compare
We want to make more changes to it soon, and we may as well not be dependent on a external repository
ghost
force-pushed
the
64-annotations-oneOf
branch
from
03cac59 to
0b2c131
Compare
openownership/lib-cove-bods#64 This involves changes to build_schemas_for_testing that are required by the change from anyOf to oneOf. But actually, this code should have been required before but the compile tool was not processing anyOf properly. OpenDataServices/compile-to-json-schema#28 #376
ghost
force-pushed
the
64-annotations-oneOf
branch
from
0b2c131 to
a7bbdde
Compare
rhiaro
approved these changes
Nov 4, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openownership/lib-cove-bods#64
Overview
What does this pull request do?
Changes part of schema to be technically correct and add a hint field so we get better validation messages
How can a reviewer test or examine your changes?
No changes to data model. To see changes in validation messages:
Who is best placed to review it?
Already discussed with @rhiaro and @kd-ods
Relates to issue: openownership/lib-cove-bods#64
Translations
translating. See: https://openownership.github.io/bods-dev-handbook/translations.html - There are none.
Documentation & Release
https://openownership.github.io/bods-dev-handbook/standard_releases.html I think this is possible to release in 0.2.1 and that would be better than 0.3 just because users will see the better validation messages faster